Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC #46352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
But you also need to run pre-commits :) |
Contributor
Author
|
Thanks for the reminder! All the static check errors have been fixed. Next time, I'll remember to use |
nailo2c
force-pushed
the
feature/sql-related-docs-refactor
branch
from
122c353 to
19439ce
Compare
eladkal
reviewed
Feb 2, 2025
eladkal
reviewed
Feb 2, 2025
eladkal
approved these changes
Feb 3, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 3, 2025
…e/Presto/Vertica/ODBC (apache#46352) * add oracle docs & dag example
Contributor
|
It seems/smells like this PR broke main. Docs build fails now in https://github.com/apache/airflow/actions/runs/13109792195/job/36571965268 Can this be fixed short term or shall we revert this PR and re-fix it? |
amoghrajesh
added a commit
to amoghrajesh/airflow
that referenced
this pull request
Feb 3, 2025
…es/Oracle/Presto/Vertica/ODBC (apache#46352)" This reverts commit 454afb5.
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
…e/Presto/Vertica/ODBC (apache#46352) * add oracle docs & dag example
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
…es/Oracle/Presto/Vertica/ODBC (apache#46352)" (apache#46368) This reverts commit 454afb5.
Contributor
Author
|
Hi, thanks for reverting. Let me check what happened later. |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
…e/Presto/Vertica/ODBC (apache#46352) * add oracle docs & dag example
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
…es/Oracle/Presto/Vertica/ODBC (apache#46352)" (apache#46368) This reverts commit 454afb5.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…e/Presto/Vertica/ODBC (apache#46352) * add oracle docs & dag example
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…es/Oracle/Presto/Vertica/ODBC (apache#46352)" (apache#46368) This reverts commit 454afb5.
Contributor
|
@nailo2c can you resubmit the PR and we will look into what was the issue? |
Contributor
Author
Contributor
|
Ah cool. Will you raise PR for the other peoviders listed in the issue that were not yet handled? |
Contributor
Author
|
Yes, I'm working on that. I hope I won't encounter the same issue in the next PR. |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…e/Presto/Vertica/ODBC (apache#46352) * add oracle docs & dag example
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…es/Oracle/Presto/Vertica/ODBC (apache#46352)" (apache#46368) This reverts commit 454afb5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44807
I used the command
breeze build-docslocally, and all the docs seem okay.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.