Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

@amoghrajesh amoghrajesh commented Feb 5, 2025

retryhttp released 1.3.0 and seems like clients using it run into mypy issues

providers/edge/src/airflow/providers/edge/cli/api_client.py:66: error: Never
not callable  [misc]
    @retry(
     ^
Found 1 error in 1 file (checked [36](https://github.com/apache/airflow/actions/runs/13148605736/job/36692383263#step:6:37)88 source files)
Error 1 returned

Example https://github.com/apache/airflow/actions/runs/13148605736/job/36692383263

The issue is either mypy or retryhttp, testing this as a potential fix.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:task-sdk provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Feb 5, 2025
@amoghrajesh
Copy link
Contributor Author

If this one goes through, will raise an issue against retry http.

@amoghrajesh
Copy link
Contributor Author

Closing and reopening to run all tests

@amoghrajesh amoghrajesh closed this Feb 5, 2025
@amoghrajesh amoghrajesh reopened this Feb 5, 2025
@amoghrajesh
Copy link
Contributor Author

amoghrajesh commented Feb 5, 2025

Created a bug against retryhttp: austind/retryhttp#20

@amoghrajesh amoghrajesh merged commit 699171a into apache:main Feb 5, 2025
156 checks passed
@potiuk
Copy link
Member

potiuk commented Feb 5, 2025

nice!

@jscheffl
Copy link
Contributor

jscheffl commented Feb 5, 2025

Oh, just saw this late - THANKS for fixing!

insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks

* making it <1.3.0
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks

* making it <1.3.0
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks

* making it <1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants