-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Limiting retryhttp to not use 1.3.0 to fix CI mypy checks #46446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If this one goes through, will raise an issue against retry http. |
Contributor
Author
|
Closing and reopening to run all tests |
jedcunningham
approved these changes
Feb 5, 2025
eladkal
approved these changes
Feb 5, 2025
Contributor
Author
|
Created a bug against retryhttp: austind/retryhttp#20 |
Member
|
nice! |
Contributor
|
Oh, just saw this late - THANKS for fixing! |
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks * making it <1.3.0
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks * making it <1.3.0
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Limiting retryhttp to not use 1.3.0 to fix CI mypy checks * making it <1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retryhttp released 1.3.0 and seems like clients using it run into mypy issues
Example https://github.com/apache/airflow/actions/runs/13148605736/job/36692383263
The issue is either mypy or retryhttp, testing this as a potential fix.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.