Skip to content

Replace caplog with mocking log methods in wasb tests. #46539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Feb 6, 2025
Merged

Replace caplog with mocking log methods in wasb tests. #46539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions providers/tests/microsoft/azure/hooks/test_wasb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,24 +528,26 @@ def test_delete_container(self, mocked_blob_service_client):
mocked_container_client.return_value.delete_container.assert_called()

@pytest.mark.parametrize("exc", [ValueError, RuntimeError])
def test_delete_container_generic_exception(self, exc: type[Exception], caplog):
def test_delete_container_generic_exception(self, exc: type[Exception]):
hook = WasbHook(wasb_conn_id=self.azure_shared_key_test)
with mock.patch.object(WasbHook, "_get_container_client") as m:
with (
mock.patch.object(WasbHook, "_get_container_client") as m,
mock.patch.object(hook.log, "error") as log_mock,
):
m.return_value.delete_container.side_effect = exc("FakeException")
caplog.clear()
caplog.set_level("ERROR")
with pytest.raises(exc, match="FakeException"):
hook.delete_container("mycontainer")
assert "Error deleting container: mycontainer" in caplog.text
log_mock.assert_called_with("Error deleting container: %s", "mycontainer")

def test_delete_container_resource_not_found(self, caplog):
def test_delete_container_resource_not_found(self):
hook = WasbHook(wasb_conn_id=self.azure_shared_key_test)
with mock.patch.object(WasbHook, "_get_container_client") as m:
with (
mock.patch.object(WasbHook, "_get_container_client") as m,
mock.patch.object(hook.log, "warning") as log_mock,
):
m.return_value.delete_container.side_effect = ResourceNotFoundError("FakeException")
caplog.clear()
caplog.set_level("WARNING")
hook.delete_container("mycontainer")
assert "Unable to delete container mycontainer (not found)" in caplog.text
log_mock.assert_called_with("Unable to delete container %s (not found)", "mycontainer")

@mock.patch.object(WasbHook, "delete_blobs")
def test_delete_single_blob(self, delete_blobs, mocked_blob_service_client):
Expand Down