AIP 84 - Add auth to connections #47194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
jason810496
reviewed
Feb 28, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Looks good ! Left some comments for test cases naming and discussion for using lambda in requires_access_<entity>.
rawwar
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
…AIP-84/auth/connections
…AIP-84/auth/connections
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice overall.
Just the spec issue, same as other permissions PR that we need to figure out. The spec shouldn't be updated because of the permission decorator.
rawwar
force-pushed
the
kalyan/AIP-84/auth/connections
branch
from
e824a8c to
81e3879
Compare
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
* add auth to connections * fix * fix failing test
47 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* add auth to connections * fix * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #42360