AIP-84 | Fix Merged Permission for Connections and Pools #47345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requires_access_connection: is_authorized_pool -> is_authorized_connection - use lambda instead of new callback function - add type hint for requires_access_<entity> - user type hint should be BaseUser instead of optional BaseUser
- retrieve auth_manger from app.state instead of creating a new one
jason810496
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
pierrejeambrun
approved these changes
Mar 4, 2025
Member
|
Thanks |
pierrejeambrun
changed the title
Member
Author
All CI are green 🎉 |
Contributor
|
@jason810496 , Thank you! |
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
* Fix security - requires_access_connection: is_authorized_pool -> is_authorized_connection - use lambda instead of new callback function - add type hint for requires_access_<entity> - user type hint should be BaseUser instead of optional BaseUser * Fix conftest of api_fastapi - retrieve auth_manger from app.state instead of creating a new one
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Fix security - requires_access_connection: is_authorized_pool -> is_authorized_connection - use lambda instead of new callback function - add type hint for requires_access_<entity> - user type hint should be BaseUser instead of optional BaseUser * Fix conftest of api_fastapi - retrieve auth_manger from app.state instead of creating a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42360
What
Fix #47194, #47129
airflow/api_fastapi/core_api/security.pyrequires_access_connectionfunction ( should callis_authorized_connectioninstead ofis_authorized_pool)lamdainstead of adding new callback definition in eachrequires_access_<entity>requires_access_<entity>( except forrequires_access_dag, the AIP-84 | Add Auth for Dags #47062 PR will add type hint for the dag one )tests/api_fastapi/conftest.pyapp.stateinstead of creating a new one