Remove regexp from dag.partial_subset method and update callers#47360
Merged
potiuk merged 3 commits intoapache:mainfrom Mar 7, 2025
Merged
Conversation
bugraoz93
requested review from
XD-DENG,
ashb,
ephraimbuddy and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:API
potiuk
approved these changes
Mar 4, 2025
Contributor
Author
Thank you, Pierre, for your review! I will address your comments shortly. |
bugraoz93
force-pushed
the
feat/46971/remove-regexp-from-partial-subset
branch
from
799813b to
c747407
Compare
pierrejeambrun
approved these changes
Mar 6, 2025
Member
There was a problem hiding this comment.
I think the unnecessary str cast remains, it got omitted in c747407 otherwise LGTM.
Contributor
Author
Thanks for the review! My bad! Haven't realised it stayed. I assumed it was gone and resolved the thread. I will delete that in the coming hours |
bugraoz93
force-pushed
the
feat/46971/remove-regexp-from-partial-subset
branch
from
c747407 to
3d2d9e9
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 7, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache#47360 and opened issue apache#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 7, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache#47360 and opened issue apache#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
potiuk
added a commit
that referenced
this pull request
Mar 7, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged #47360 and opened issue #47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…he#47360) * Remove regexp from dag.partial_subset method and update callers * Remove casting and convert list checking to old method * Remove not needed casting
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache#47360 and opened issue apache#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 28, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache/airflow#47360 and opened issue apache/airflow#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2. GitOrigin-RevId: 092cc57f0257c55bfa4e7db9aa91d9c2525bca41
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 24, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache/airflow#47360 and opened issue apache/airflow#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2. GitOrigin-RevId: 092cc57f0257c55bfa4e7db9aa91d9c2525bca41
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache/airflow#47360 and opened issue apache/airflow#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2. GitOrigin-RevId: 092cc57f0257c55bfa4e7db9aa91d9c2525bca41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #46971
After thread discussions and discussions in the dev meeting. I updated the regexp usage on the API side. I searched and have never found a place in Airflow where the method
partial_subsetis called with regexp. So updating it hasn't impacted too many places.Follow-up: Enhance API request validation to catch any regexp usage for
strfields and return errors independent from the endpoint. This will enhance and cover all API request #47364^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.