-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Get rid of google-re2 as dependency #47493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
approved these changes
Mar 7, 2025
Member
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lets see if the CI agrees.
eladkal
approved these changes
Mar 7, 2025
Member
Author
It does not :) |
Member
Author
"navbar_color": (re.compile(r"(?i)\A#007A87\z"), "#fff", "2.1"),
File "/usr/local/lib/python3.9/re.py", line 252, in compile
return _compile(pattern, flags)
File "/usr/local/lib/python3.9/re.py", line 304, in _compile
p = sre_compile.compile(pattern, flags)
File "/usr/local/lib/python3.9/sre_compile.py", line 788, in compile
p = sre_parse.parse(p, flags)
File "/usr/local/lib/python3.9/sre_parse.py", line 955, in parse
p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0)
File "/usr/local/lib/python3.9/sre_parse.py", line 444, in _parse_sub
itemsappend(_parse(source, state, verbose, nested + 1,
File "/usr/local/lib/python3.9/sre_parse.py", line 526, in _parse
code = _escape(source, this, state)
File "/usr/local/lib/python3.9/sre_parse.py", line 427, in _escape
raise source.error("bad escape %s" % escape, len(escape))
re.error: bad escape \z at position 13😱 |
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache#47360 and opened issue apache#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
a44c038 to
39fa9d1
Compare
bugraoz93
approved these changes
Mar 7, 2025
Contributor
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Lots of stuff moving so making CI happy is even harder :)
hussein-awala
approved these changes
Mar 7, 2025
gopidesupavan
approved these changes
Mar 7, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged apache#47360 and opened issue apache#47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:API
Airflow's REST/HTTP API
area:CLI
area:dev-tools
area:logging
area:serialization
kind:documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged #47360 and opened issue #47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.