Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 7, 2025

Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm and PR merged #47360 and opened issue #47364 ideal that could prevent new additions of regexp to UI. I think it's time to remove google-re2.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets see if the CI agrees.

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2025

Nice, lets see if the CI agrees.

It does not :)

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2025

   "navbar_color": (re.compile(r"(?i)\A#007A87\z"), "#fff", "2.1"),
    File "/usr/local/lib/python3.9/re.py", line 252, in compile
      return _compile(pattern, flags)
    File "/usr/local/lib/python3.9/re.py", line 304, in _compile
      p = sre_compile.compile(pattern, flags)
    File "/usr/local/lib/python3.9/sre_compile.py", line 788, in compile
      p = sre_parse.parse(p, flags)
    File "/usr/local/lib/python3.9/sre_parse.py", line 955, in parse
      p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0)
    File "/usr/local/lib/python3.9/sre_parse.py", line 444, in _parse_sub
      itemsappend(_parse(source, state, verbose, nested + 1,
    File "/usr/local/lib/python3.9/sre_parse.py", line 526, in _parse
      code = _escape(source, this, state)
    File "/usr/local/lib/python3.9/sre_parse.py", line 427, in _escape
      raise source.error("bad escape %s" % escape, len(escape))
  re.error: bad escape \z at position 13

😱

Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm
and PR merged apache#47360 and
opened issue apache#47364 ideal that could
prevent new additions of regexp to UI. I think it's time to remove
google-re2.
@potiuk potiuk force-pushed the get-rid-of-google-re2 branch from a44c038 to 39fa9d1 Compare March 7, 2025 13:34
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Lots of stuff moving so making CI happy is even harder :)

@potiuk potiuk merged commit 092cc57 into apache:main Mar 7, 2025
148 checks passed
@potiuk potiuk deleted the get-rid-of-google-re2 branch March 7, 2025 15:09
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Following discusison in https://lists.apache.org/thread/nnttnblj3tcv2wqj79gwovtfhgq8lvmm
and PR merged apache#47360 and
opened issue apache#47364 ideal that could
prevent new additions of regexp to UI. I think it's time to remove
google-re2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants