Automatically set API base_url to a good value so UI is reachable locally #49013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ashb,
bbovenzi,
ephraimbuddy,
gopidesupavan,
jedcunningham,
jscheffl,
potiuk,
rawwar,
ryanahamilton and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
ashb
reviewed
Apr 9, 2025
ashb
force-pushed
the
48825-fix-default-base-url
branch
from
1fe0297 to
ed9adac
Compare
Member
|
I pushed a couple of changes -- (not tests yet, sorry) -- this was enough to get it working locally under any name I could reach in the browser, localhost, 127.0.0.1, and |
Member
Author
|
I just fixed / added a few tests. I was able to verify the dagrun link for triggered dag run too: |
pierrejeambrun
commented
Apr 10, 2025
Member
Author
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Breeze is working nicely (dev-mode vs non-dev mode as well as with url prefix /d12345/).
Member
Author
|
A couple more tests need fixing and we should be good to go. |
Whatever URL the browser made the request on obviously works, so lets use that for the base url in our templates, rather than what ever is hard-coded in the config.
This also adjusts `is_safe_url` so that it validates against wither the configure base_url, or against the incoming base URL -- either one is allowed.
pierrejeambrun
force-pushed
the
48825-fix-default-base-url
branch
from
6020625 to
7fa0eba
Compare
pierrejeambrun
force-pushed
the
48825-fix-default-base-url
branch
from
7fa0eba to
6b3fc59
Compare
ashb
reviewed
Apr 10, 2025
ashb
approved these changes
Apr 10, 2025
ashb
changed the title
Contributor
|
This introduced a bug when running Airflow with Breeze, it redirects the user to |
This was referenced Apr 10, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #48825
This need additional work: