Set AIRFLOW__API__BASE_URL in Breeze
#49065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
Member
|
I'd really really like us to find a way that doesn't involve needing to set BASE_URL for this use case -- that was 90% of the reason for the change in #49013 in the first place. Why can't it redirect to |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
+1 for Ash comment. SimpleAuthManager do not need this, and Fab shouldn't too.
vincbeck
force-pushed
the
vincbeck/fab_login
branch
from
16db4ac to
675fc8b
Compare
Contributor
Author
|
When I set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49013 introduced a bug. If you try to login with FAB auth manager with Breeze, you'll get redirected to
localhost:8080, which does not exist (the external endpoint provided by Breeze islocalhost:28080). In that case, we need to setAIRFLOW__API__BASE_URLto specify the API server endpoint.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.