Always create serdag in dagmaker fixture #50359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
reviewed
May 8, 2025
Contributor
ephraimbuddy
left a comment
ephraimbuddy
left a comment
There was a problem hiding this comment.
I worked on making it backwards compatible here: https://github.com/apache/airflow/pull/46703/files#diff-b666e1a99da023285548b78cbdf107890577203173a6ab31fb0722491ed1b280.
You might want to take a look
Contributor
Author
Sorry, making what backward compatible? |
Contributor
Like still allowing the use of non-serialized for airflow 2 |
dstandish
force-pushed
the
always-create-serdag-in-dagmaker
branch
from
1fdbbfd to
d3c08d7
Compare
dstandish
added
the
full tests needed
This was referenced May 9, 2025
dstandish
force-pushed
the
always-create-serdag-in-dagmaker
branch
from
dfedfb2 to
6e015d9
Compare
dstandish
force-pushed
the
always-create-serdag-in-dagmaker
branch
from
7581992 to
802fc6d
Compare
ephraimbuddy
approved these changes
May 14, 2025
uranusjr
reviewed
May 14, 2025
uranusjr
reviewed
May 14, 2025
uranusjr
reviewed
May 14, 2025
uranusjr
reviewed
May 14, 2025
The serializaed trigger must be JSON-compatible to be stored in the database, so we may need to run it through BaseSerialization. I added some extra code so the serialization is done at a minimum, and not shown to the user if possible.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
dstandish
force-pushed
the
always-create-serdag-in-dagmaker
branch
from
8a8b4d2 to
df4f242
Compare
dstandish
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2025
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- (cherry picked from commit 229d1b2) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Backport successfully created: v3-0-test
|
dstandish
added a commit
that referenced
this pull request
May 21, 2025
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- (cherry picked from commit 229d1b2) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- (cherry picked from commit 229d1b2) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
kaxil
reviewed
Jul 1, 2025
| @@ -230,12 +230,26 @@ def __str__(self) -> str: | |||
|
|
|||
|
|
|||
| def _encode_trigger(trigger: BaseEventTrigger | dict): | |||
Member
There was a problem hiding this comment.
The changes in this PR potentially caused regression: #51809
Mis-leading PR title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model.
It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this).
Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is.