[v3-0-test] Always create serdag in dagmaker fixture (#50359) #50900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- (cherry picked from commit 229d1b2) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
boring-cyborg
bot
added
area:API
potiuk
approved these changes
May 21, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model. It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this). Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is. --------- (cherry picked from commit 229d1b2) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so dag_maker always creates serialized dag and dagversion objects, along with dag model.
It's not really sensible anymore to not have these other objects there; they are always there in production, and increasingly we need them there for code to work right, and their omission can leave some bugs hidden (and some of them are resolved as part of this).
Initially, I was going to just remove the option, but, it also controls the type of dag object returned by dag_maker (serdag vs dag), so for now I leave that as is.
(cherry picked from commit 229d1b2)
Co-authored-by: Daniel Standish 15932138+dstandish@users.noreply.github.com
Co-authored-by: Tzu-ping Chung uranusjr@gmail.com