-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Refactor(i18n): Modify filter reset key & update zh-TW files #51363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care! Good for DE and EN! (Other I can not judge but looking OK)
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/dashboard.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, using variables in the translation is usually the way to go when the sentences do not match 1 for 1 and need a complete reword.
Can't vouch for translation quality but I like the approach
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes lgtm. I'll defer to others for the zh-tw updates
…51363) * Refactor(i18n): Modify filter reset key & update zh-TW files * i18n: update dashboard.json for zh-TW * modify zh-TW translations
Related PRs
#51181
#51242
cc @bbovenzi
This PR includes two main improvements:
1. Filter Reset Button Refactor:
Why:
To better support the grammatical structures of different languages (e.g., some languages don't require spaces between words, or tend to have verb-final sentence structures).
Before:
After:
Translation Key Updates:
filterResethas been immediately updated forde,en,pl, andzh-TW.Screenshots of the corrected UI:

2.
zh-TW(Traditional Chinese) Translation Updates:Based on the previous discussion in PR #51242, the Traditional Chinese translations have been updated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.