Skip to content

Conversation

@RoyLee1224
Copy link
Contributor

Related PRs

#51181
#51242

cc @bbovenzi

This PR includes two main improvements:

1. Filter Reset Button Refactor:

Why:
To better support the grammatical structures of different languages (e.g., some languages don't require spaces between words, or tend to have verb-final sentence structures).

  • Before:

    <LuX /> {translate("table.filters.reset")}{" "}
          {filterCount === 1 ? translate("table.filters.filter_one") : translate("table.filters.filter_other")}
  • After:

    <LuX />{translate("table.filterReset", { count: filterCount })}
  • Translation Key Updates:

    • The new translation key filterReset has been immediately updated for de,en,pl, andzh-TW.
    • Action Required: Kindly request the respective language Code Owners to review these new translations.

Screenshots of the corrected UI:
filter_langs

2. zh-TW (Traditional Chinese) Translation Updates:

Based on the previous discussion in PR #51242, the Traditional Chinese translations have been updated.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 3, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care! Good for DE and EN! (Other I can not judge but looking OK)

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using variables in the translation is usually the way to go when the sentences do not match 1 for 1 and need a complete reword.

Can't vouch for translation quality but I like the approach

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm. I'll defer to others for the zh-tw updates

@Lee-W Lee-W merged commit 709955f into apache:main Jun 5, 2025
43 checks passed
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
…51363)

* Refactor(i18n): Modify filter reset key & update zh-TW files

* i18n: update dashboard.json for zh-TW

* modify zh-TW translations
@RoyLee1224 RoyLee1224 deleted the fix/i18n/filters branch June 12, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants