Update dag version when bundle name changes #51901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
XD-DENG,
ashb and
jedcunningham
as code owners
ephraimbuddy
force-pushed
the
update-serdag-version-when-bundle-name-changes
branch
from
5cda8bc to
ff82265
Compare
ephraimbuddy
added
the
backport-to-v3-1-test
jedcunningham
approved these changes
Jun 18, 2025
ephraimbuddy
force-pushed
the
update-serdag-version-when-bundle-name-changes
branch
from
ff82265 to
dd5077d
Compare
If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change. This issue was fixed in apache#49886 but the fix randomly assigned versions to the new bundle.
ephraimbuddy
force-pushed
the
update-serdag-version-when-bundle-name-changes
branch
from
dd5077d to
b040c18
Compare
Contributor
Author
|
@jedcunningham , I'm changing this to create new version when the bundle changes. The reason is this: if there's a run before the change of bundle name, updating the version means altering history since the run would appear as if from the new bundle whereas it was from the old bundle. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* Update dag version when bundle name changes If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change. This issue was fixed in #49886 but the fix randomly assigned versions to the new bundle. * fixup! Update dag version when bundle name changes * fixup! fixup! Update dag version when bundle name changes * fixup! fixup! fixup! Update dag version when bundle name changes * Change this to create new version when the bundle name changes (cherry picked from commit cc7abdc) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Backport successfully created: v3-0-test
|
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
* Update dag version when bundle name changes If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change. This issue was fixed in apache#49886 but the fix randomly assigned versions to the new bundle. * fixup! Update dag version when bundle name changes * fixup! fixup! Update dag version when bundle name changes * fixup! fixup! fixup! Update dag version when bundle name changes * Change this to create new version when the bundle name changes
kaxil
pushed a commit
that referenced
this pull request
Jul 2, 2025
) If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change. This issue was fixed in #49886 but the fix randomly assigned versions to the new bundle. * fixup! Update dag version when bundle name changes * fixup! fixup! Update dag version when bundle name changes * fixup! fixup! fixup! Update dag version when bundle name changes * Change this to create new version when the bundle name changes (cherry picked from commit cc7abdc) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change.
This issue was fixed in #49886 but the fix randomly assigned versions to the new bundle.