[v3-0-test] Update dag version when bundle name changes (#51901) #51939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dag version when bundle name changes If there's a bundle name change without the dag structure changing, we should update the dag version to reflect the change. This issue was fixed in #49886 but the fix randomly assigned versions to the new bundle. * fixup! Update dag version when bundle name changes * fixup! fixup! Update dag version when bundle name changes * fixup! fixup! fixup! Update dag version when bundle name changes * Change this to create new version when the bundle name changes (cherry picked from commit cc7abdc) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
boring-cyborg
bot
added
area:API
potiuk
requested review from
XD-DENG,
ashb,
ephraimbuddy and
jedcunningham
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a bundle name change without the dag structure changing,
we should update the dag version to reflect the change.
This issue was fixed in #49886 but the fix randomly assigned versions
to the new bundle.
fixup! Update dag version when bundle name changes
fixup! fixup! Update dag version when bundle name changes
fixup! fixup! fixup! Update dag version when bundle name changes
Change this to create new version when the bundle name changes
(cherry picked from commit cc7abdc)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com