[v3-0-test] Make log redaction safer in edge case when redaction has an error (#54046)

[github-actions]

(cherry picked from commit 93ba1c5)

Co-authored-by: Ash Berlin-Taylor ash@apache.org

[ashb]

@potiuk curious. This passed on main but failed on back port

[potiuk]

@potiuk curious. This passed on main but failed on back port

Interesting

[potiuk]

 Error was: AttributeError: 'str' object has no attribute 'to_dict'

[potiuk]

Looks like #53047 should be cherry-picked as well. Seems that mypy already found the path that of running to_dict() on string that @gopidesupavan fixed in #53047

[potiuk]

I think few more changes for typing should be cherry-picked too.. Interesting thing that it actually revealed a case that potentially secrets could be revealed without bad input - by bug in our code BTW :)

[ashb]

Hmmmm, looking at the code and the test it "should" be fine, that hasattr check shouldn't be needed.

[ashb]

It's a bad test is why --

with patch("airflow.sdk.execution_time.secrets_masker._is_v1_env_var", return_value=True): is always returning true, even when it's called with a plain string.

[potiuk]

Ah.. Cool