Fix DAG trigger UI error for DAGs with parameters #56833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheerajturaga
requested review from
amoghrajesh,
ashb,
bolkedebruin,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
Member
Author
|
the simple auth manager change is from prek hook |
The API endpoint for DAG details was returning only resolved parameter values instead of the full parameter schema, causing a "Cannot read properties of undefined (reading section)" error in the UI when triggering DAGs with parameters. This was a regression introduced in commit 5d58c04 which changed `v.dump()` to `v.resolve()` in the params serialization. Changes: - Add `serialize()` method to `SerializedParam` to return the full parameter structure (value, description, schema) - Update API field validator to use `serialize()` instead of `resolve()` - Update tests to expect the correct parameter format The API now returns params in the format expected by the frontend: {"param_name": {"value": <val>, "description": <desc>, "schema": {...}}}
dheerajturaga
force-pushed
the
bugfix/fix-trigger-params-api-schema
branch
from
6a5c568 to
173f4a4
Compare
Contributor
|
PR to fix this was already raised - #56831 |
Contributor
|
I'd also favor #56831 over this one because it is a bit more complete (includes task and not only dag) and was earlier. Nevertheless still both do not full fix the problem. The Dag "Params Trigger UI" is repaired but still Dag "Params UI tutorial" raises an error and form is empty: |
Member
Author
|
Closing this in favor of #56831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API endpoint for DAG details was returning only resolved parameter
values instead of the full parameter schema, causing a "Cannot read
properties of undefined (reading section)" error in the UI when
triggering DAGs with parameters.
This was a regression introduced in commit #55111 which changed
v.dump()tov.resolve()in the params serialization.Changes:
serialize()method toSerializedParamto return the full parameter structure (value, description, schema)serialize()instead ofresolve()The API now returns params in the format expected by the frontend:
{"param_name": {"value": , "description": , "schema": {...}}}
Error when you hit
triggeron dag run page:cc: @kaxil