Fix DAG params API contract broken by #55111 #56831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredthomsen
requested review from
ashb,
bolkedebruin,
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
fredthomsen
force-pushed
the
fixBadParamSchema
branch
2 times, most recently
from
2bc505b to
25dfb46
Compare
fredthomsen
force-pushed
the
fixBadParamSchema
branch
from
25dfb46 to
5ce419d
Compare
Contributor
|
Checked - and thanks for the fix! But a small nit in serialization still blocks "Params UI Tutorial" Dag is you start this from examples: |
jscheffl
added
the
backport-to-v3-1-test
Member
|
Changed the GH milestone for this & #55111 to 3.2.0 -- to not risk any regression in 3.1.1 |
Contributor
Author
|
@jscheffl ah yikes. Ok update made. |
PR apache#55111 introduced SerializedParam to decouple from the Task SDK, but inadvertently broke the API contract by changing `.dump()` to `.resolve()` in the params serialization. This caused the UI to crash because FlexibleForm expects the full param spec with {value, schema, description} but was receiving only the resolved values. The original SDK Param class had a `.dump()` method that returned the full spec, so this restores the API contract rather than creating new behavior. Related: apache#55111
jscheffl
force-pushed
the
fixBadParamSchema
branch
from
d738ad2 to
b1ac129
Compare
jscheffl
approved these changes
Oct 20, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good now and is working fine with the examples I have. LGTM... after CI is made happy.
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 4791bbb v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Member
|
@jscheffl need manual backport |
Contributor
|
@kaxil why is this labeled with 3.1 backport while the milestone is 3.2.0? |
jscheffl
removed
the
backport-to-v3-1-test
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #55111 introduced SerializedParam to decouple from the Task SDK, but inadvertently broke the API contract by changing
.dump()to.resolve()in the params serialization. This caused the UI to crash because FlexibleForm expects the full param spec with {value, schema, description} but was receiving only the resolved values.The original SDK Param class had a
.dump()method that returned the full spec, so this restores the API contract rather than creating new behavior.Related: #55111
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.