Fix UI crash when triggering a param dag #56896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When triggering the example dag 'Params trigger Ui' via the UI,
the form crashed with:
TypeError: Cannot read properties of null (reading 'value')
at src/queries/useParamStore.ts:setParamsDict
This was because the `useDagParams` returned raw
backend params(plain values that can be null), but `setParamsDict`
expects each entry to be a ParamSpec with a .value.
When a value was null, destructuring { value } caused the crash.
The fix was to normalize `data.params` in `useDagParams.ts` to ParamSpec objects
ephraimbuddy
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
Another error type: 
|
eladkal
approved these changes
Oct 21, 2025
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
Does this affect only main or also 3.1?
Member
|
Does #56831 affect this? |
Contributor
Author
No. Doesn't affect 3.1 |
Contributor
Author
Yea, fixed by that too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When triggering the example dag 'Params trigger Ui' via the UI, the form crashed with:
TypeError: Cannot read properties of null (reading 'value') at src/queries/useParamStore.ts:setParamsDict
This was because the
useDagParamsreturned rawbackend params(plain values that can be null), but
setParamsDictexpects each entry to be a ParamSpec with a .value. When a value was null, destructuring { value } caused the crash.The fix was to normalize
data.paramsinuseDagParams.tsto ParamSpec objects