Remove PriorityWeightStrategy reference in SDK #59780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
uranusjr
force-pushed
the
sdk-weight-rule
branch
5 times, most recently
from
5b2df0c to
6deb312
Compare
uranusjr
requested review from
amoghrajesh,
ashb,
bolkedebruin,
hussein-awala,
jedcunningham and
kaxil
as code owners
kaxil
reviewed
Dec 24, 2025
kaxil
approved these changes
Dec 24, 2025
This follows mainly the Timetable Treatment (tm) (patent pending) i.e. allow stub values to be stored in SDK constructs and delay validation to during dag processing, but ALSO allow custom subclasses to be seamlessly serialized and decoded. Users CAN use PriorityWeightStrategy subclasses with SDK types if they want to. The SDK classes simply store them. After validation in the dag processor, protected processes will only see PriorityWeightStrategy objects.
We'll need to figure a lot of things out in CLI down the road...
uranusjr
force-pushed
the
sdk-weight-rule
branch
from
6deb312 to
fb5a09c
Compare
Contributor
|
Have a suspect that this PR broke canary tests in https://github.com/apache/airflow/actions/runs/20523379840 - somebody able to check? |
Contributor
|
Fix attempt: #59826 |
jscheffl
added a commit
that referenced
this pull request
Dec 26, 2025
Dev-iL
pushed a commit
to Dev-iL/airflow
that referenced
this pull request
Dec 28, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
* Revert "Remove PriorityWeightStrategy reference in SDK (apache#59780)" This reverts commit 60b4ed4. * Tip by TP
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Revert "Remove PriorityWeightStrategy reference in SDK (apache#59780)" This reverts commit 60b4ed4. * Tip by TP
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Revert "Remove PriorityWeightStrategy reference in SDK (apache#59780)" This reverts commit 60b4ed4. * Tip by TP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows mainly the Timetable Treatment™️ (patent pending) i.e. allow stub values to be stored in SDK constructs and delay validation to during dag processing, but ALSO allow custom subclasses to be seamlessly serialized and decoded.
Users CAN use PriorityWeightStrategy subclasses with SDK types if they want to. The SDK classes simply store them. After validation in the dag processor, protected processes will only see PriorityWeightStrategy objects.
See #52141 (although this ends up being actually more the other way around, removing Core references in SDK).