TaskInstance unused method cleanup #59835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
full tests needed
uranusjr
force-pushed
the
try-fix-priority-weight
branch
from
db312d8 to
af353e9
Compare
uranusjr
requested review from
amoghrajesh,
bolkedebruin,
hussein-awala,
jedcunningham and
kaxil
as code owners
uranusjr
added
the
all versions
uranusjr
force-pushed
the
try-fix-priority-weight
branch
3 times, most recently
from
b1471e5 to
10fad34
Compare
uranusjr
force-pushed
the
try-fix-priority-weight
branch
5 times, most recently
from
4c643c3 to
4c587bc
Compare
Dev-iL
reviewed
Dec 28, 2025
uranusjr
force-pushed
the
try-fix-priority-weight
branch
9 times, most recently
from
10e9bd9 to
a1553bc
Compare
uranusjr
requested review from
gopidesupavan,
jason810496,
josh-fell,
mobuchowski and
o-nikolas
as code owners
kaxil
reviewed
Dec 29, 2025
kaxil
approved these changes
Dec 29, 2025
Member
|
#protm |
kaxil
reviewed
Dec 29, 2025
kaxil
reviewed
Dec 29, 2025
kaxil
reviewed
Dec 29, 2025
uranusjr
force-pushed
the
try-fix-priority-weight
branch
2 times, most recently
from
095d1f5 to
e9c29f0
Compare
potiuk
reviewed
Dec 29, 2025
potiuk
approved these changes
Dec 29, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. One small question - but I think it's more important to merge this one and fix any follow-ups later
Member
|
I think some e2e (related) tests fail with this change: 
|
uranusjr
force-pushed
the
try-fix-priority-weight
branch
from
e9c29f0 to
a227559
Compare
uranusjr
changed the title
3 tasks
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Fix Pytest plugin * Simplify serialized dag access * Fix core test * Replace ti.run() with test util * Remove ti.render_templates() and clean up providers
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Fix Pytest plugin * Simplify serialized dag access * Fix core test * Replace ti.run() with test util * Remove ti.render_templates() and clean up providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out trying to fix #59780 but ended up doing a big operation planned for later.
The original intention was to find a way to make #59780 pass all version combinations, but the provider tests have so many leftover quirks from before 3.0, I decided to take apart all of those instead, to keep the compat layer simpler and easier to understand. This also allows us to do a couple of long-waited cleanups in Core:
test_utils.taskinstance) with free functions that implement a compat layer to be used in providers instead. This contributes to most changes in this PR.This is a very big one, but should not be logically difficult to review. Just the same changes over and over again across all providers.
I want to also remove TaskInstance.get_template_context() after this is removed. That one is also never used in 3.x.