Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Dec 14, 2024

What changes were proposed in this pull request?

Problem: build tries to download release artifacts from apache-snapshots repo, and non-Apache artifacts from apache-releases repo.

[INFO] Downloading from apache-releases: https://repository.apache.org/content/repositories/releases/com/google/guava/guava/28.0-jre/guava-28.0-jre.pom
[INFO] Downloading from apache-snapshots: https://repository.apache.org/content/repositories/snapshots/com/google/guava/guava/28.0-jre/guava-28.0-jre.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/google/guava/guava/28.0-jre/guava-28.0-jre.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/com/google/guava/guava/28.0-jre/guava-28.0-jre.pom (8.7 kB at 513 kB/s)

Fix:

  • disable release artifacts in apache-snapshots
  • remove apache-releases repo, use central (inherited) instead

https://issues.apache.org/jira/browse/AMBARI-26264

How was this patch tested?

$ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories
...
[INFO] --- toolbox:0.6.0:list-repositories (default-cli) @ ambari-metrics ---
[INFO] Remote repositories used by project org.apache.ambari:ambari-metrics:pom:3.1.0-SNAPSHOT.
[INFO]  * central (https://repo.maven.apache.org/maven2/, default, releases)
[INFO]    First introduced on root
[INFO]  * apache-snapshots (https://repository.apache.org/content/repositories/snapshots, default, snapshots)
[INFO]    First introduced on root

Local build.

@adoroszlai adoroszlai changed the title AMBARI-26264. Disable releases for apache-napshots repo AMBARI-26264. Disable releases for apache-snapshots repo Dec 14, 2024
@adoroszlai
Copy link
Contributor Author

@JiaLiangC @arshadmohammad please review

Failing tests are due to AMBARI-26142, as mentioned in #134 (comment)

@adoroszlai
Copy link
Contributor Author

@JiaLiangC @arshadmohammad can you please help review this?

@JiaLiangC
Copy link
Contributor

@adoroszlai Sorry for the late reply. When you @ us here, the project members don't actually receive email notifications. You can send an email, @ us in the issue, or submit a PR in the Apache Ambari project.

@adoroszlai
Copy link
Contributor Author

Thanks @JiaLiangC for the response. I'll keep that in mind.

or submit a PR in the Apache Ambari project

I'm not sure how I could submit it in https://github.com/apache/ambari, the code to be changed is in this repo.

@jojochuang
Copy link
Contributor

LGTM.
The failure is unrelated. Opened https://issues.apache.org/jira/browse/AMBARI-26325 to track the fix.

@jojochuang jojochuang merged commit 3fe435f into apache:master Mar 14, 2025
1 check failed
@adoroszlai adoroszlai deleted the AMBARI-26264 branch March 17, 2025 07:52
@adoroszlai
Copy link
Contributor Author

Thanks @jojochuang for reviewing and merging this.

JiaLiangC added a commit to JiaLiangC/ambari-metrics that referenced this pull request Mar 20, 2025
* master:
  AMBARI-26327: Fix ambari-metrics-monitor start failure (apache#143)
  Revert "AMBARI-26142: JDK17 support for Ambari-metrics (apache#134)" (apache#142)
  AMBARI-26264. Disable releases for apache.snapshots repo (apache#138)
  AMBARI-25954 Upgrade ignite-core to 2.1.0 to 2.15.0 (apache#114)
  [AMBARI-26184] Resolve snakeyaml 0.12 CVE (apache#136)
  AMBARI-26142: JDK17 support for Ambari-metrics (apache#134)
  [AMBARI-26135] Upgrade net.sf.ehcache to 3.10.0 (apache#132)
  status: command not found (apache#125)
  [AMBARI-26095] Upgrade Grafana version 9.5.5 to 11.1.4 (apache#129)
  [AMBARI-26134]Resolve Test case failures in Ambari Metrics host Monitoring (apache#133)
  AMBARI-26123:Ambari-metrics build failed apache#130
  AMBARI-26020: upgrade Ambari Metrics to python3 (apache#126)
  AMBARI-25998: Host uuid is not getting synced to other collectors, causing NPE while accessing metric (apache#124)
jojochuang pushed a commit to jojochuang/ambari-metrics that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants