Revert "AMBARI-26142: JDK17 support for Ambari-metrics" #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 667fa9a.
Contributor
Author
Contributor
|
Actually we shouldn't revert JDK17 changes. Since Ambari-metrics is running on JDK17, it will encourage other dependent components to upgrade JDK to JDK17. @brahmareddybattula @arshadmohammad @virajjasani what's your view on this? how should be handle this? |
JiaLiangC
added a commit
to JiaLiangC/ambari-metrics
that referenced
this pull request
Mar 20, 2025
* master: AMBARI-26327: Fix ambari-metrics-monitor start failure (apache#143) Revert "AMBARI-26142: JDK17 support for Ambari-metrics (apache#134)" (apache#142) AMBARI-26264. Disable releases for apache.snapshots repo (apache#138) AMBARI-25954 Upgrade ignite-core to 2.1.0 to 2.15.0 (apache#114) [AMBARI-26184] Resolve snakeyaml 0.12 CVE (apache#136) AMBARI-26142: JDK17 support for Ambari-metrics (apache#134) [AMBARI-26135] Upgrade net.sf.ehcache to 3.10.0 (apache#132) status: command not found (apache#125) [AMBARI-26095] Upgrade Grafana version 9.5.5 to 11.1.4 (apache#129) [AMBARI-26134]Resolve Test case failures in Ambari Metrics host Monitoring (apache#133) AMBARI-26123：Ambari-metrics build failed apache#130 AMBARI-26020: upgrade Ambari Metrics to python3 (apache#126) AMBARI-25998: Host uuid is not getting synced to other collectors, causing NPE while accessing metric (apache#124)
jojochuang
pushed a commit
to jojochuang/ambari-metrics
that referenced
this pull request
Apr 21, 2025
…pache#142) This reverts commit 667fa9a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "AMBARI-26142: JDK17 support for Ambari-metrics (#134)"
This reverts commit 667fa9a.
Reason for revert:
The JDK17 upgrade for Ambari-metrics has caused compatibility issues with various component sinks (Hadoop, HBase, etc.) that are still running on JDK8. Since Ambari-metrics produces JAR files that serve as plugins for these components, the JDK17-compiled sinks are not compatible with the JDK8 runtime environment of the host components.
Specifically, when Hadoop (which runs on JDK8) attempts to load the metrics sink compiled with JDK17, it fails to start due to bytecode incompatibility issues. This incompatibility affects multiple components that integrate with Ambari-metrics.
We need to revert to the JDK8-compatible version until we can implement a solution that maintains backward compatibility with JDK8-based components or until all dependent components are upgraded to support JDK17.