Fix ambari-metrics-grafana start scipt only check pid file exist. #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where when the metrics-grafana service was stopped outside the Ambari interface, attempting to start Grafana through the Ambari interface would incorrectly report the service as already running while Grafana had actually failed to start. The resolution addresses this state mismatch and ensures proper service status synchronization.
Author
|
@JiaLiangC Can you review the code? JiaLiang. |
JiaLiangC
reviewed
Apr 3, 2025
| return 0 | ||
| fi | ||
| else | ||
| return 1 |
Contributor
There was a problem hiding this comment.
There is a case where the PID file does not exist, but the process is still running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ambari-metrics-grafana start scipt only check pid file exist.
This commit fixes a bug where when the metrics-grafana service was stopped outside the Ambari interface, attempting to start Grafana through the Ambari interface would incorrectly report the service as already running while Grafana had actually failed to start. The resolution addresses this state mismatch and ensures proper service status synchronization.