Skip to content

Fix ambari-metrics-grafana start scipt only check pid file exist. #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MingDu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ambari-metrics-grafana start scipt only check pid file exist. #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,22 @@ fi
DAEMON_OPTS="--pidfile=${PID_FILE} --config=${CONF_FILE} cfg:default.paths.data=${DATA_DIR} cfg:default.paths.logs=${LOG_DIR}"

function isRunning() {
test -e "$PID_FILE"
if [ -f ${PID_FILE} ]; then
PID=`cat ${PID_FILE}`
if [ -z "`ps ax -o pid | grep -w ${PID}`" ]; then
echo "${PID_FILE} found with no process. Removing ${PID}..."
rm -f ${PID_FILE}
return 1
else
tput bold
echo "WARN: Grafana already running with PID: ${PID}"
tput sgr0
echo "Exiting."
return 0
fi
else
return 1
Copy link
Contributor

@JiaLiangC JiaLiangC Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a case where the PID file does not exist, but the process is still running.

fi
}

case "$1" in
Expand Down