allow SliceableCursor to be constructed from an Arc directly
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes apache#368.
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 162 162
Lines 44175 44175
==========================================
- Hits 36491 36490 -1
- Misses 7684 7685 +1
Continue to review full report at Codecov.
|
alamb
pushed a commit
that referenced
this pull request
Jun 4, 2021
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368.
alamb
added a commit
that referenced
this pull request
Jun 5, 2021
… (#401) This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368. Co-authored-by: Marco Neumann <marco@crepererum.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backwards-compatible since we change the argument from
Vec<u8>to
impl Into<Arc<Vec<u8>>>and the following implementations exists instd:
impl<T, U> Into<U> for T where U: From<T>(reverse direction)impl<T> From<T> for Arc<T>(createArcfrom any type)Furthermore
Arc<Vec<u8>>can be passed directly now because the followingimplementations exists:
impl<T> From<T> for T(identity)Closes #368.