Cherry pick allow SliceableCursor to be constructed from an Arc directly to active_release
#401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is backwards-compatible since we change the argument from `Vec<u8>` to `impl Into<Arc<Vec<u8>>>` and the following implementations exists in std: - `impl<T, U> Into<U> for T where U: From<T>` (reverse direction) - `impl<T> From<T> for Arc<T>` (create `Arc` from any type) Furthermore `Arc<Vec<u8>>` can be passed directly now because the following implementations exists: - `impl<T> From<T> for T` (identity) Closes #368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of b802895
SliceableCursorto be constructed from anArcdirectly #369: allowSliceableCursorto be constructed from anArcdirectly