Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Aug 27, 2021

Which issue does this PR close?

specifying rust 1.53 for arrow and parquet crate.

related #714, as in here the pat_params is introduced.

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 27, 2021
@jimexist
Copy link
Member Author

actually this doesn't work.

see also https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-rust-version-field but sadly this is nightly

@jimexist jimexist marked this pull request as draft August 27, 2021 01:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #724 (d64b62c) into master (deb31a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files         168      168           
  Lines       47647    47647           
=======================================
  Hits        39317    39317           
  Misses       8330     8330           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb31a0...d64b62c. Read the comment docs.

@houqp
Copy link
Member

houqp commented Aug 27, 2021

I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.

@jimexist
Copy link
Member Author

I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.

sadly this option is ready in 1.56 by which time rust edition 2021 is already out

@Dandandan
Copy link
Contributor

I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.

sadly this option is ready in 1.56 by which time rust edition 2021 is already out

For now it only displays a warning, no?

@alamb
Copy link
Contributor

alamb commented Aug 28, 2021

An alternate is to document that arrow rs only tests on the latest rust stable: #726

If the goal is to ensure that the arrow and parquet crates work on Rust 1.53 I suggest we add a CI run that at least cargo checks that they can be compiled with 1.53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants