Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 28, 2021

Rationale for this change

@jhorstmann noticed a change that was introduced in #714 (comment) (and included in the arrow 5.3.0 RC0) that is incompatible with rust 1.52.1 (rust is currently on 1.54.0).

What changes are included in this PR?

Propose explicitly document that arrow and parquet are only tested with the latest stable version of Rust.

Though this maybe also should serve as a way to solicit opinions about how important compatibility with older versions of Rust is (and if anyone would be willing to spend the time to setup CI to make sure that happens)

Are there any user-facing changes?

Different readme

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #726 (c924015) into master (5a12d97) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   82.50%   82.51%   +0.01%     
==========================================
  Files         168      168              
  Lines       47589    47631      +42     
==========================================
+ Hits        39261    39301      +40     
- Misses       8328     8330       +2     
Impacted Files Coverage Δ
parquet_derive_test/src/lib.rs 100.00% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 68.86% <0.00%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a12d97...c924015. Read the comment docs.

Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houqp houqp merged commit 6ee9bc0 into apache:master Aug 28, 2021
@alamb alamb deleted the alamb/readme branch August 29, 2021 10:23
alamb added a commit that referenced this pull request Sep 9, 2021
* Add a note on rust compiler testing and compatibility

* prettier
alamb added a commit that referenced this pull request Sep 9, 2021
* Add a note on rust compiler testing and compatibility

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants