Skip to content

[CI][C++] Skyhook needs to follow Dataset's API change #14990

@kou

Description

@kou

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/3699926875/jobs/6267820480

FAILED: src/skyhook/CMakeFiles/arrow_skyhook_objlib.dir/client/file_skyhook.cc.o 
/usr/local/bin/sccache /usr/bin/c++  -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_MIMALLOC -DARROW_NO_DEPRECATED_API -DARROW_WITH_RE2 -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DBOOST_ALL_NO_LIB -Isrc -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/thirdparty/flatbuffers/include -isystem /arrow/cpp/thirdparty/hadoop/include -isystem orc_ep-install/include -isystem protobuf_ep-install/include -isystem google_cloud_cpp_ep-install/include -isystem absl_ep-install/include -isystem crc32c_ep-install/include -isystem awssdk_ep-install/include -isystem opentelemetry_ep-install/include -isystem xsimd_ep/src/xsimd_ep-install/include -isystem jemalloc_ep-prefix/src -isystem mimalloc_ep/src/mimalloc_ep/include/mimalloc-2.0 -Wno-noexcept-type  -fdiagnostics-color=always -ggdb -O0  -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -Werror -fno-semantic-interposition -msse4.2  -g -fPIC   -pthread -std=c++17 -MD -MT src/skyhook/CMakeFiles/arrow_skyhook_objlib.dir/client/file_skyhook.cc.o -MF src/skyhook/CMakeFiles/arrow_skyhook_objlib.dir/client/file_skyhook.cc.o.d -o src/skyhook/CMakeFiles/arrow_skyhook_objlib.dir/client/file_skyhook.cc.o -c /arrow/cpp/src/skyhook/client/file_skyhook.cc
/arrow/cpp/src/skyhook/client/file_skyhook.cc: In constructor 'skyhook::SkyhookFileFormat::SkyhookFileFormat(std::shared_ptr<skyhook::RadosConnCtx>, std::string)':
/arrow/cpp/src/skyhook/client/file_skyhook.cc:135:61: error: no matching function for call to 'arrow::dataset::FileFormat::FileFormat()'
  135 |     : impl_(new Impl(std::move(ctx), std::move(file_format))) {}
      |                                                             ^
In file included from /arrow/cpp/src/arrow/dataset/file_parquet.h:30,
                 from /arrow/cpp/src/skyhook/client/file_skyhook.h:22,
                 from /arrow/cpp/src/skyhook/client/file_skyhook.cc:17:
/arrow/cpp/src/arrow/dataset/file_base.h:206:12: note: candidate: 'arrow::dataset::FileFormat::FileFormat(std::shared_ptr<arrow::dataset::FragmentScanOptions>)'
  206 |   explicit FileFormat(std::shared_ptr<FragmentScanOptions> default_fragment_scan_options)
      |            ^~~~~~~~~~
/arrow/cpp/src/arrow/dataset/file_base.h:206:12: note:   candidate expects 1 argument, 0 provided
/arrow/cpp/src/arrow/dataset/file_base.h:145:23: note: candidate: 'arrow::dataset::FileFormat::FileFormat(const arrow::dataset::FileFormat&)'
  145 | class ARROW_DS_EXPORT FileFormat : public std::enable_shared_from_this<FileFormat> {
      |                       ^~~~~~~~~~
/arrow/cpp/src/arrow/dataset/file_base.h:145:23: note:   candidate expects 1 argument, 0 provided
[936/947] Building CXX object src/skyhook/CMakeFiles/cls_skyhook_objlib.dir/cls/cls_skyhook.cc.o
[937/947] Building CXX object src/skyhook/CMakeFiles/skyhook-cls-test.dir/cls/cls_skyhook_test.cc.o
ninja: build stopped: subcommand failed.

Cc: @JayjeetAtGithub

Component(s)

C++

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions