Skip to content

GH-14990: [C++][Skyhook] Follow FileFormat API change #15086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Dec 25, 2022
Merged

GH-14990: [C++][Skyhook] Follow FileFormat API change #15086

kou merged 1 commit into from
Dec 25, 2022

Conversation

@kou
Copy link
Member

@kou kou commented Dec 24, 2022 •
edited by github-actions bot
Loading

arrow::dataset::FileFormat's constructor API was changed in ARROW-17288/GH-14663.

@kou
apacheGH-14990: [C++][Skyhook] Follow FileFormat() API change
d81c8dd 
`arrow::dataset::FileFormat`'s constructor API was changed in
ARROW-17288/apacheGH-14663.
@kou kou changed the title GH-14990: [C++][Skyhook] Follow FileFormat() API change GH-14990: [C++][Skyhook] Follow FileFormat API change Dec 24, 2022
@github-actions
Copy link

github-actions bot commented Dec 24, 2022

@kou
Copy link
Member Author

kou commented Dec 24, 2022

@github-actions crossbow submit test-skyhook-integration

@github-actions
Copy link

github-actions bot commented Dec 24, 2022

⚠️ GitHub issue #14990 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 24, 2022

Revision: d81c8dd

Submitted crossbow builds: ursacomputing/crossbow @ actions-6a59663746

Task Status
test-skyhook-integration Github Actions

@kou kou merged commit 8e9165e into apache:master Dec 25, 2022
@kou kou deleted the cpp-skyhook-follow-api-change branch December 25, 2022 20:36
@ursabot
Copy link

ursabot commented Dec 25, 2022

Benchmark runs are scheduled for baseline = 474b1a5 and contender = 8e9165e. 8e9165e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8e9165e8 ec2-t3-xlarge-us-east-2
[Failed] 8e9165e8 test-mac-arm
[Finished] 8e9165e8 ursa-i9-9960x
[Finished] 8e9165e8 ursa-thinkcentre-m75q
[Finished] 474b1a5e ec2-t3-xlarge-us-east-2
[Failed] 474b1a5e test-mac-arm
[Finished] 474b1a5e ursa-i9-9960x
[Finished] 474b1a5e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@westonpace
Copy link
Member

westonpace commented Dec 26, 2022

Thanks!

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@kou @EpsilonPrime
apacheGH-14990: [C++][Skyhook] Follow FileFormat API change (apache#1…
aa2d6da 
…5086)

`arrow::dataset::FileFormat`'s constructor API was changed in ARROW-17288/apacheGH-14663.
* Closes: apache#14990

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI][C++] Skyhook needs to follow Dataset's API change

4 participants

@kou @ursabot @westonpace @lidavidm