Skip to content

Conversation

@liyafan82
Copy link
Contributor

Some APIs representing unsupported operations should not be annotated deprecated, unless the overriden APIs are deprecated in the super classes/interfaces.

According to the discussion in #10864 (comment), we open a separate issue for this.

@github-actions
Copy link

@emkornfield
Copy link
Contributor

Sorry, instead of removing the deprecated flag, it might be better to document why they are marked deprecated.

@liyafan82
Copy link
Contributor Author

Sorry, instead of removing the deprecated flag, it might be better to document why they are marked deprecated.

SGTM. Documents added. Thanks.

After more thoughts, I think some API should be deprecated completely (that is, the API in the interface and all implementations should be deprecated.)
This is because, the APIs no longer reflect the current design.

Do you agree?

@emkornfield
Copy link
Contributor

+1 Thanks, I think this makes sense. Lets wait one release and then we can delete the methods marked as being removed.

CC @laurentgo

ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
…ing unsupported operations

Some APIs representing unsupported operations should not be annotated deprecated, unless the overriden APIs are deprecated in the super classes/interfaces.

According to the discussion in apache#10864 (comment), we open a separate issue for this.

Closes apache#10911 from liyafan82/fly_0811_ano

Authored-by: liyafan82 <fan_li_ya@foxmail.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…ing unsupported operations

Some APIs representing unsupported operations should not be annotated deprecated, unless the overriden APIs are deprecated in the super classes/interfaces.

According to the discussion in apache#10864 (comment), we open a separate issue for this.

Closes apache#10911 from liyafan82/fly_0811_ano

Authored-by: liyafan82 <fan_li_ya@foxmail.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants