Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions java/vector/src/main/codegen/templates/DenseUnionVector.java
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,13 @@ private void setReaderAndWriterIndex() {
offsetBuffer.writerIndex((long) valueCount * OFFSET_WIDTH);
}

/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Override
@Deprecated
public List<BufferBacked> getFieldInnerVectors() {
Expand Down
9 changes: 8 additions & 1 deletion java/vector/src/main/codegen/templates/UnionVector.java
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,15 @@ private void setReaderAndWriterIndex() {
typeBuffer.writerIndex(valueCount * TYPE_WIDTH);
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use geFieldBuffers");
}
Expand Down
14 changes: 8 additions & 6 deletions java/vector/src/main/codegen/templates/ValueHolders.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,19 @@ public final class ${className} implements ValueHolder{
<#list fields as field>
public ${field.type} ${field.name};
</#list>

@Deprecated

/**
* Reason for not supporting the operation is that ValueHolders are potential scalar
* replacements and hence we don't want any methods to be invoked on them.
*/
public int hashCode(){
throw new UnsupportedOperationException();
}

/*
* Reason for deprecation is that ValueHolders are potential scalar replacements
* and hence we don't want any methods to be invoked on them.
/**
* Reason for not supporting the operation is that ValueHolders are potential scalar
* replacements and hence we don't want any methods to be invoked on them.
*/
@Deprecated
public String toString(){
throw new UnsupportedOperationException();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,15 @@ public void reAlloc() {
lastValueCapacity = getValueCapacity();
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,13 @@ public void clear() {
valueCount = 0;
}

/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Override
@Deprecated
public List<BufferBacked> getFieldInnerVectors() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,15 @@ public void clear() {
valueCount = 0;
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,14 @@ public List<ArrowBuf> getFieldBuffers() {
return underlyingVector.getFieldBuffers();
}

/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
return underlyingVector.getFieldInnerVectors();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ public interface FieldVector extends ValueVector {
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
List<BufferBacked> getFieldInnerVectors();

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ public List<ArrowBuf> getFieldBuffers() {
return Collections.emptyList();
}

/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
return Collections.emptyList();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ protected void reallocOffsetBuffer() {
offsetAllocationSizeInBytes = newAllocationSize;
}

/**
* Get the offset vector.
* @deprecated This API will be removed, as the current implementations no longer hold inner offset vectors.
*
* @return the underlying offset vector or null if none exists.
*/
@Override
@Deprecated
public UInt4Vector getOffsetVector() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,15 @@ private void setReaderAndWriterIndex() {
validityBuffer.writerIndex(getValidityBufferSizeFromCount(valueCount));
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,15 @@ private void setReaderAndWriterIndex() {
}
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down Expand Up @@ -442,7 +449,14 @@ public void copyFrom(int inIndex, int outIndex, ValueVector from) {
ComplexCopier.copy(in, out);
}

/**
* Get the offset vector.
* @deprecated This API will be removed, as the current implementations no longer hold inner offset vectors.
*
* @return the underlying offset vector or null if none exists.
*/
@Override
@Deprecated
public UInt4Vector getOffsetVector() {
throw new UnsupportedOperationException("There is no inner offset vector");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,15 @@ private void setReaderAndWriterIndex() {
}
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ public interface RepeatedValueVector extends ValueVector, DensityAwareVector {

/**
* Get the offset vector.
* @deprecated This API will be removed, as the current implementations no longer hold inner offset vectors.
*
* @return the underlying offset vector or null if none exists.
*/
@Deprecated
UInt4Vector getOffsetVector();

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,15 @@ private void setReaderAndWriterIndex() {
validityBuffer.writerIndex(BitVectorHelper.getValidityBufferSize(valueCount));
}

@Override
/**
* Get the inner vectors.
*
* @deprecated This API will be removed as the current implementations no longer support inner vectors.
*
* @return the inner vectors for this field as defined by the TypeLayout
*/
@Deprecated
@Override
public List<BufferBacked> getFieldInnerVectors() {
throw new UnsupportedOperationException("There are no inner vectors. Use getFieldBuffers");
}
Expand Down