ARROW-14247: [C++] Fix Valgrind errors in parquet-arrow-test #11356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@github-actions crossbow submit test-conda-cpp-valgrind |
|
Revision: 7b59970 Submitted crossbow builds: ursacomputing/crossbow @ actions-904
|
Member
Author
|
Valgrind still fails, but that should be fixed by #11350. |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Googletest prints all test parameter objects up front. When there's no custom printer defined, it just prints the bytes of the struct. This happened to go into uninitialized memory in (apparently) std::string, tripping Valgrind. See a discussion by Chromium developers on a similar issue: https://bugs.chromium.org/p/chromium/issues/detail?id=64887 Closes apache#11356 from lidavidm/arrow-14247 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Googletest prints all test parameter objects up front. When there's no custom printer defined, it just prints the bytes of the struct. This happened to go into uninitialized memory in (apparently) std::string, tripping Valgrind.
See a discussion by Chromium developers on a similar issue: https://bugs.chromium.org/p/chromium/issues/detail?id=64887