Skip to content

ARROW-14247: [C++] Fix Valgrind errors in parquet-arrow-test #11356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 1 commit into from
Closed

ARROW-14247: [C++] Fix Valgrind errors in parquet-arrow-test #11356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/parquet/arrow/arrow_schema_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,7 @@ TEST(TestFromParquetSchema, CorruptMetadata) {
::arrow::Result<std::deque<LevelInfo>> RootToTreeLeafLevels(
const SchemaManifest& manifest, int column_number) {
std::deque<LevelInfo> out;
const SchemaField* field;
const SchemaField* field = nullptr;
RETURN_NOT_OK(manifest.GetColumnField(column_number, &field));
while (field != nullptr) {
out.push_front(field->level_info);
Expand Down
10 changes: 10 additions & 0 deletions cpp/src/parquet/arrow/arrow_statistics_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ struct StatisticsTestParam {
std::string expected_max;
};

// Define a custom print since the default Googletest print trips Valgrind
void PrintTo(const StatisticsTestParam& param, std::ostream* os) {
(*os) << "StatisticsTestParam{"
<< "table.schema=" << param.table->schema()->ToString()
<< ", expected_null_count=" << param.expected_null_count
<< ", expected_value_count=" << param.expected_value_count
<< ", expected_min=" << param.expected_min
<< ", expected_max=" << param.expected_max << "}";
}

class ParameterizedStatisticsTest : public ::testing::TestWithParam<StatisticsTestParam> {
};

Expand Down