ARROW-14844: [R] Implement decimal256() #11898

dragosmg · 2021-12-08T09:50:41Z

@jonkeane & @romainfrancois this is the 2nd attempt at implementing decimal256(). First one is #11805

…ad of "

…`scale` are size 1

…ased on precision + docs

github-actions · 2021-12-08T09:51:03Z

https://issues.apache.org/jira/browse/ARROW-14844

r/R/array.R

… message if the casting fails

r/tests/testthat/test-chunked-array.R

dragosmg · 2021-12-09T13:56:10Z

It looks like the CI workflows fail for 2 reasons:

an open_dataset CSV test (BOM issue) which has nothing to do with this PR (see ARROW-15041)
failures to find and run /data-raw/codegen.R +

array_to_vector.cpp:923:62: error: typedef 'using DecimalArray = typename arrow::TypeTraits<T>::ArrayType' locally defined but not used [-Werror=unused-local-typedefs]

@romainfrancois @jonkeane Any thoughts on the array_to_vector error?

r/src/array_to_vector.cpp

r/R/array.R

r/src/array_to_vector.cpp

r/tests/testthat/test-data-type.R

r/tests/testthat/test-Array.R

…56()`

r/R/array.R

r/tests/testthat/test-Array.R

jonkeane

This looks good. Thanks for this + all of the Jiras that you created in the process!

ursabot · 2021-12-20T19:42:11Z

Benchmark runs are scheduled for baseline = 281dee5 and contender = cfcce5a. cfcce5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.24% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Follow on to #11898 Closes #12005 from jonkeane/decimal-cleanup Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>

dragosmg added 11 commits December 7, 2021 10:54

update NEWS

2957655

added tests for decimal256() and updated older tests to use ` inste…

387ae07

…ad of "

added decimal256() and check_decimal_args() functions

7ab86fc

docs

1253ba3

update datatype + generate arrowExports

e17401c

typo + namespace vec_assert() + tests checking the precision and …

df96c16

…`scale` are size 1

added test on type and dplyr funcs type

7cf85db

updated decimal() to call either decimal128() or decimal256() b…

c0bd279

…ased on precision + docs

updated NEWS with changes to decimal()

1cc6b20

updated decimal docs & tests

619a3d6

docs + lintr complaints

6162dee

github-actions bot added the Component: R label Dec 8, 2021

dragosmg added 3 commits December 8, 2021 09:54

news change

c623389

Merge branch 'master' into ARROW-14844_decimal256_take2

e737c1e

catch RPrimitiveConverter error and then cast

e9c40bc

dragosmg commented Dec 8, 2021

View reviewed changes

r/R/array.R Outdated Show resolved Hide resolved

dragosmg added 5 commits December 8, 2021 10:59

reoder decimal definitions

36f566f

reoder decimals take 2

9d0b317

attempt to return original error if casting fails

f8bfacf

revert to cnd (not cnd2)

d476428

update array$create to correctly capture and return the initial error…

307195d

… message if the casting fails

dragosmg mentioned this pull request Dec 8, 2021

ARROW-14844 [R] Implement decimal256() #11805

Closed

dragosmg added 2 commits December 9, 2021 12:56

docs + skipped the decimal256() unit test for empty ChunkedArrays

36b996d

Array$create() tries casting and gives the user a hint if it works

ea19fd3

dragosmg marked this pull request as ready for review December 9, 2021 12:57

dragosmg commented Dec 9, 2021

View reviewed changes

r/tests/testthat/test-chunked-array.R Show resolved Hide resolved

dragosmg added 2 commits December 9, 2021 13:02

slightly improved hint

20f054f

lint

c4442fb

removed the line as the C++ linter doesn't like commented code

7eb138b

romainfrancois reviewed Dec 10, 2021

View reviewed changes

r/src/array_to_vector.cpp Outdated Show resolved Hide resolved

romainfrancois reviewed Dec 10, 2021

View reviewed changes

r/src/array_to_vector.cpp Outdated Show resolved Hide resolved

add back in the definition for DecimalArray and use it

068755f

jonkeane reviewed Dec 13, 2021

View reviewed changes

r/R/array.R Show resolved Hide resolved

pitrou reviewed Dec 15, 2021

View reviewed changes

r/R/array.R Outdated Show resolved Hide resolved

r/src/array_to_vector.cpp Show resolved Hide resolved

r/tests/testthat/test-data-type.R Show resolved Hide resolved

dragosmg added 3 commits December 15, 2021 14:51

add tests for the decimal precision range

1f02407

added unit test to check the manual casting hint

e9a27f9

improve comment for the tryCatch() + try() attempts

fb1c39a

jonkeane reviewed Dec 20, 2021

View reviewed changes

r/tests/testthat/test-Array.R Outdated Show resolved Hide resolved

dragosmg added 3 commits December 20, 2021 14:52

add TODO and reference the C++ unit tests Jira ticket (ARROW-15162)

4622e22

removed superfluous unit tests

8ec06ed

added Jira ticket number to empty array filtering tests for `decimal2…

9f9031e

…56()`

jonkeane reviewed Dec 20, 2021

View reviewed changes

r/R/array.R Show resolved Hide resolved

jonkeane reviewed Dec 20, 2021

View reviewed changes

r/tests/testthat/test-Array.R Outdated Show resolved Hide resolved

test Array$create() fallback is as expected when casting doesn't work

6640e8c

dragosmg requested a review from jonkeane December 20, 2021 19:06

use expect_equal when comparing messages

db7148d

jonkeane approved these changes Dec 20, 2021

View reviewed changes

jonkeane changed the title ~~ARROW-14844_decimal256_take2~~ ARROW-14844: [R] Implement decimal256() Dec 20, 2021

jonkeane closed this in cfcce5a Dec 20, 2021

dragosmg mentioned this pull request Dec 20, 2021

ARROW-15170 [R] ignore attributes when testing Array$create error messages #12003

Closed

jonkeane mentioned this pull request Dec 20, 2021

MINOR: [R] Clean up an overly-specific test #12005

Closed

jonkeane added a commit that referenced this pull request Dec 20, 2021

MINOR: [R] Clean up an overly-specific test

9ac9405

Follow on to #11898 Closes #12005 from jonkeane/decimal-cleanup Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>

dragosmg deleted the ARROW-14844_decimal256_take2 branch February 24, 2022 09:25

This was referenced Dec 21, 2021

[R] Implement decimal256() #30373

Closed

[R] Improve efficiency of decimal casting #20043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ARROW-14844: [R] Implement decimal256() #11898

ARROW-14844: [R] Implement decimal256() #11898

Uh oh!

dragosmg commented Dec 8, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Dec 8, 2021

Uh oh!

Uh oh!

Uh oh!

dragosmg commented Dec 9, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonkeane left a comment

Uh oh!

ursabot commented Dec 20, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ARROW-14844: [R] Implement decimal256() #11898

ARROW-14844: [R] Implement decimal256() #11898

Uh oh!

Conversation

dragosmg commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 8, 2021

Uh oh!

Uh oh!

Uh oh!

dragosmg commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonkeane left a comment

Choose a reason for hiding this comment

Uh oh!

ursabot commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dragosmg commented Dec 8, 2021 •

edited

Loading

dragosmg commented Dec 9, 2021 •

edited

Loading

ursabot commented Dec 20, 2021 •

edited

Loading