Skip to content

Conversation

@dragosmg
Copy link
Contributor

@dragosmg dragosmg commented Dec 20, 2021

This addresses the failing tests (on CentOS and Windows) introduced by the decimal256() implementation (PR #11898).

The failure was due to a mismatch in names between actual and expected. On some systems one is an empty character vector, while the other one is NULL.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@dragosmg dragosmg changed the title ignore attributes when comparing error messages ARROW-15170 [R] ignore attributes when testing Array$create error messages Dec 20, 2021
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@dragosmg dragosmg marked this pull request as ready for review December 20, 2021 20:26
@dragosmg
Copy link
Contributor Author

Closing this PR and the issue has been solved in #12005.

@dragosmg dragosmg closed this Dec 21, 2021
@dragosmg dragosmg deleted the ARROW-15170_ignore_attr_array_create_test branch April 26, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant