Skip to content

ARROW-14590: [R] Implement lubridate::week #12097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlenkaF wants to merge 3 commits into from
Closed

ARROW-14590: [R] Implement lubridate::week #12097

AlenkaF wants to merge 3 commits into from

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Jan 7, 2022

This PR adds the implementation of lubridate::week following the way it is calculated in lubridate.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

https://issues.apache.org/jira/browse/ARROW-14590

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

thisisnic
thisisnic reviewed Jan 7, 2022
View reviewed changes
thisisnic
thisisnic reviewed Jan 7, 2022
View reviewed changes
thisisnic
thisisnic approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though let's have @dragosmg and @jonkeane check I'm not missing anything.

@dragosmg
Copy link
Contributor

dragosmg commented Jan 12, 2022

LGTM

@thisisnic thisisnic requested a review from jonkeane January 12, 2022 16:26
jonkeane
jonkeane approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks! My only comment is basically "Odd, but true! It's too simple to believe!" 😂

@jonkeane jonkeane closed this in d1fb8e7 Jan 12, 2022
@ursabot
Copy link

ursabot commented Jan 12, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = b582af1 and contender = d1fb8e7. d1fb8e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.45%] ursa-i9-9960x
[Failed ⬇️0.31% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the ARROW-14590 branch January 13, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rok rok rok left review comments

@thisisnic thisisnic thisisnic approved these changes

@jonkeane jonkeane jonkeane approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AlenkaF @dragosmg @ursabot @rok @jonkeane @thisisnic