Skip to content

ARROW-14590: [R] Implement lubridate::week #12097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlenkaF wants to merge 3 commits into from
Closed

ARROW-14590: [R] Implement lubridate::week #12097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3b584a
Add implementation of lubridate::week
AlenkaF Jan 7, 2022
5cfb0a1
Add a test for date and call C++ function for division
AlenkaF Jan 10, 2022
1761696
Revert to %/%
AlenkaF Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions r/R/dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options = list(count_from_zero = FALSE, week_start = week_start))
})

register_binding("week", function(x) {
(call_binding("yday", x) - 1) %/% 7 + 1
})

register_binding("month", function(x, label = FALSE, abbr = TRUE, locale = Sys.getlocale("LC_TIME")) {
if (label) {
if (abbr) {
Expand Down
18 changes: 18 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,15 @@ test_that("extract epiweek from timestamp", {
)
})

test_that("extract week from timestamp", {
compare_dplyr_binding(
.input %>%
mutate(x = week(datetime)) %>%
collect(),
test_df
)
})

test_that("extract day from timestamp", {
compare_dplyr_binding(
.input %>%
Expand Down Expand Up @@ -529,6 +538,15 @@ test_that("extract epiweek from date", {
)
})

test_that("extract week from date", {
compare_dplyr_binding(
.input %>%
mutate(x = week(date)) %>%
collect(),
test_df
)
})

test_that("extract month from date", {
compare_dplyr_binding(
.input %>%
Expand Down