Skip to content

ARROW-15788: [C++][FlightRPC] Prepare benchmark for alternative transports #12524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidavidm wants to merge 1 commit into from
Closed

ARROW-15788: [C++][FlightRPC] Prepare benchmark for alternative transports #12524

lidavidm wants to merge 1 commit into from

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Feb 28, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

https://issues.apache.org/jira/browse/ARROW-15788

@lidavidm lidavidm mentioned this pull request Mar 8, 2022
Closed
@lidavidm lidavidm marked this pull request as ready for review March 14, 2022 18:21
@lidavidm
Copy link
Member Author

lidavidm commented Mar 14, 2022

CC @cyb70289 if you'd like to take a look, this is just a minor refactoring to minimize the amount of churn that will be in #12442

cyb70289
cyb70289 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidavidm lidavidm closed this in b203c66 Mar 15, 2022
@lidavidm lidavidm deleted the arrow-15788 branch March 15, 2022 13:31
@ursabot
Copy link

ursabot commented Mar 15, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 98cdb73 and contender = b203c66. b203c66 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @ursabot @cyb70289