-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15706: [C++][FlightRPC] Implement a UCX transport #12442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TODOs Prerequisite JIRAs:
Remaining work here:
|
|
|
e67b653 to
0a10ba1
Compare
31f89ca to
9bce9d3
Compare
839109c to
3a0279e
Compare
|
Thanks @lidavidm ! |
|
cc @shamisp if you are interested. |
|
|
cyb70289
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with current code.
We can leave TODOs and other improvements as follow up tasks.
Unfortunately I'm not able to benchmark this PR soon and there's some issue of the lab test network but I cannot go to office recently.
|
@cyb70289 thanks for all the feedback. I'll file JIRA issues for any TODOs before merging. |
…g to an IPv6 address
|
TODOs filed (and noted in the source) ARROW-10787 [C++][Flight] DoExchange doesn't support dictionary replacement |
|
I see many TSAN errors from flight tests (I tested on an Arm server).
|
|
Hmm, indeed. Filed ARROW-16135. It's old, but grpc/grpc#16749 claims you need to build gRPC itself with TSAN. Maybe this also applies to UCX. |
|
Benchmark runs are scheduled for baseline = e5072bd and contender = 542158f. 542158f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |


This PR implements a UCX-based transport for Arrow Flight in C++ based on the transport interfaces added in ARROW-15282. Currently, it supports DoExchange/DoGet/DoPut (i.e., all the data methods) and GetFlightInfo. It supports multiple concurrent calls on a single client, like gRPC (though with caveats; see the documentation) and can run the Flight benchmark.