ARROW-15932: [C++][FlightRPC] Add more tests to the common Flight suite #12628
Conversation
cpp/src/arrow/flight/flight_test.cc
Outdated
There was a problem hiding this comment.
Are these definitions meant to be repeated for each backend? If so, should there be a convenience macro so that none of them is forgotten?
There was a problem hiding this comment.
I added convenience macros. GTest's value-parameterized tests would work better for this but I couldn't get the Windows build to work out (GTest thought that the same test fixture had been defined multiple times and would error on startup)
There was a problem hiding this comment.
Should we test for a specific status code here (IOError perhaps)?
There was a problem hiding this comment.
Changed to test for IOError.
There was a problem hiding this comment.
What happens if counter % 2 == 0? Should we assert that there's no app metadata?
There was a problem hiding this comment.
Should we use checked_cast here?
There was a problem hiding this comment.
Should we have a CheckBuffersOnDevice overload for record batches?
|
Benchmark runs are scheduled for baseline = 331fc44 and contender = 6a2c432. 6a2c432 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
Expand the common Flight suite with some edge cases discovered while testing UCX (ARROW-15706). Also, factor the Flight client's handling of non-host memory types out of the gRPC transport and into the common code.