-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15515: [C++] Update ExecPlan example code and documentation with new options #12689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
|
|
cc @westonpace included the Do you think we should replace the collector function |
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a few wording suggestions. This will conflict with #12721 so one of the two will need to rebase (which gets merged second).
|
@westonpace Thank you for the review. I will address these issues. |
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few minor grammatical suggestions.
|
Benchmark runs are scheduled for baseline = fe11431 and contender = 7d4e93d. 7d4e93d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR includes a documentation update for streaming execution engine and a
table_sinkexample.