Skip to content

ARROW-17112: [Java] Fix a failure of TestArrowReaderWriter.testFileFooterSizeOverflow on s390x #13638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Jul 19, 2022
Merged

ARROW-17112: [Java] Fix a failure of TestArrowReaderWriter.testFileFooterSizeOverflow on s390x #13638

kou merged 1 commit into from
Jul 19, 2022

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Jul 18, 2022 •
edited
Loading

TestArrowReaderWriter.testFileFooterSizeOverflow in arrow-vectors always causes a failure on s390x. This is because the test code stores footer length in platform native-endian buffer while footer length is stored as little-endian in a footer.

This PR fixes only the test code.

@github-actions
Copy link

github-actions bot commented Jul 18, 2022

https://issues.apache.org/jira/browse/ARROW-17112

@github-actions
Copy link

github-actions bot commented Jul 18, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kiszk kiszk mentioned this pull request Jul 18, 2022
Merged
@kou kou merged commit 8fd3067 into apache:master Jul 19, 2022
@ursabot
Copy link

ursabot commented Jul 19, 2022

Benchmark runs are scheduled for baseline = d81d845 and contender = 8fd3067. 8fd3067 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.35% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 8fd30672 ec2-t3-xlarge-us-east-2
[Failed] 8fd30672 test-mac-arm
[Failed] 8fd30672 ursa-i9-9960x
[Finished] 8fd30672 ursa-thinkcentre-m75q
[Failed] d81d8451 ec2-t3-xlarge-us-east-2
[Failed] d81d8451 test-mac-arm
[Failed] d81d8451 ursa-i9-9960x
[Finished] d81d8451 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@kiszk @kou
ARROW-17112: [Java] Fix a failure of TestArrowReaderWriter.testFileFo…
ba65662 
…oterSizeOverflow on s390x (apache#13638)

`TestArrowReaderWriter.testFileFooterSizeOverflow` in arrow-vectors always causes a failure on s390x. This is because the test code stores footer length in platform native-endian buffer while footer length is stored as little-endian in a footer.

This PR fixes only the test code.


Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiszk @ursabot @lidavidm @kou