Skip to content

Conversation

@rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Nov 29, 2022

@rtpsw
Copy link
Contributor Author

rtpsw commented Nov 29, 2022

cc @westonpace

@github-actions
Copy link

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! This will be needed for extension relations.

Marking "request changes" because we should also add relation.h to src/arrow/engine/api.h

Comment on lines +19 to +20

#include "arrow/compute/exec/exec_plan.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "arrow/compute/exec/exec_plan.h"
#include <memory>
#include "arrow/compute/exec/exec_plan.h"

Minor IWYU nit

@westonpace westonpace merged commit ce73832 into apache:master Dec 7, 2022
@ursabot
Copy link

ursabot commented Dec 7, 2022

Benchmark runs are scheduled for baseline = 9b0f3d7 and contender = ce73832. ce73832 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.03% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.52% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ce738320 ec2-t3-xlarge-us-east-2
[Failed] ce738320 test-mac-arm
[Finished] ce738320 ursa-i9-9960x
[Finished] ce738320 ursa-thinkcentre-m75q
[Finished] 9b0f3d71 ec2-t3-xlarge-us-east-2
[Finished] 9b0f3d71 test-mac-arm
[Finished] 9b0f3d71 ursa-i9-9960x
[Finished] 9b0f3d71 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants