Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/arrow/engine/api.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@

#include "arrow/engine/substrait/extension_set.h"
#include "arrow/engine/substrait/extension_types.h"
#include "arrow/engine/substrait/relation.h"
#include "arrow/engine/substrait/serde.h"
37 changes: 37 additions & 0 deletions cpp/src/arrow/engine/substrait/relation.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

#pragma once

#include <memory>

#include "arrow/compute/exec/exec_plan.h"
Comment on lines +21 to +22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "arrow/compute/exec/exec_plan.h"
#include <memory>
#include "arrow/compute/exec/exec_plan.h"

Minor IWYU nit

#include "arrow/type_fwd.h"

namespace arrow {
namespace engine {

/// Information resulting from converting a Substrait relation.
struct ARROW_ENGINE_EXPORT DeclarationInfo {
/// The compute declaration produced thus far.
compute::Declaration declaration;

std::shared_ptr<Schema> output_schema;
};

} // namespace engine
} // namespace arrow
9 changes: 1 addition & 8 deletions cpp/src/arrow/engine/substrait/relation_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "arrow/compute/exec/exec_plan.h"
#include "arrow/engine/substrait/extension_types.h"
#include "arrow/engine/substrait/options.h"
#include "arrow/engine/substrait/relation.h"
#include "arrow/engine/substrait/serde.h"
#include "arrow/engine/substrait/visibility.h"
#include "arrow/type_fwd.h"
Expand All @@ -31,14 +32,6 @@
namespace arrow {
namespace engine {

/// Information resulting from converting a Substrait relation.
struct DeclarationInfo {
/// The compute declaration produced thus far.
compute::Declaration declaration;

std::shared_ptr<Schema> output_schema;
};

/// \brief Convert a Substrait Rel object to an Acero declaration
ARROW_ENGINE_EXPORT
Result<DeclarationInfo> FromProto(const substrait::Rel&, const ExtensionSet&,
Expand Down