WIP: [R] Verify CRAN release-11.0.0-rc0#33952
WIP: [R] Verify CRAN release-11.0.0-rc0#33952thisisnic wants to merge 1 commit intoapache:release-11.0.0-rc0from
Conversation
…ild (apache#33847) ### Rationale for this change Some base type classes don't have hidden method implementations. It may define these classes in each translation unit. It may cause one-definition-rule violation with `-flto`. ### What changes are included in this PR? Define at least one hidden method to prevent defining these base type classes in each translation unit. ### Are these changes tested? How to reproduce: ```bash CFLAGS="-flto" CXXFLAGS="-flto" cmake ... cmake --build ... ``` This reports link errors without this change. ### Are there any user-facing changes? No. * Closes: apache#33701 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
@github-actions crossbow submit --group r |
|
Revision: 9543e10 Submitted crossbow builds: ursacomputing/crossbow @ actions-b14e29c074 |
|
I just kicked off a revdep run using: cd path/to/arrow
R -e 'usethis::pr_fetch(33952)`
archery docker run r-revdepcheck |
|
Ok - there are no changes for the worse reported by the archery revdep job; however, I'd like to test it by hand too using my hacked-together method (probably tomorrow morning). |
|
OK, so the valgrind failure is one we know about, but wasn't the devdocs one that @paleolimbot already fixed? |
|
Ah, it's this: #33898 Though it's not failing on the nightlies any more. |
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 9543e10 Submitted crossbow builds: ursacomputing/crossbow @ actions-831234295c
|
Do not review/merge; this is just part of the R release process