Skip to content

WIP: [R] Verify CRAN release-11.0.0-rc0#33952

Closed
thisisnic wants to merge 1 commit intoapache:release-11.0.0-rc0from
thisisnic:r-11.0.0
Closed

WIP: [R] Verify CRAN release-11.0.0-rc0#33952
thisisnic wants to merge 1 commit intoapache:release-11.0.0-rc0from
thisisnic:r-11.0.0

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Jan 31, 2023

Do not review/merge; this is just part of the R release process

…ild (apache#33847)

### Rationale for this change

Some base type classes don't have hidden method implementations. It may define these classes in each translation unit. It may cause one-definition-rule violation with `-flto`.

### What changes are included in this PR?

Define at least one hidden method to prevent defining these base type classes in each translation unit.

### Are these changes tested?

How to reproduce:

```bash
CFLAGS="-flto" CXXFLAGS="-flto" cmake ...
cmake --build ...
```

This reports link errors without this change.

### Are there any user-facing changes?

No.
* Closes: apache#33701

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@thisisnic
Copy link
Member Author

@github-actions crossbow submit --group r

@github-actions
Copy link

Revision: 9543e10

Submitted crossbow builds: ursacomputing/crossbow @ actions-b14e29c074

Task Status
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-r41 Azure
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions
r-binary-packages Github Actions
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-dev-duckdb Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-gcc-12 Github Actions
test-r-install-local Github Actions
test-r-install-local-minsizerel Github Actions
test-r-library-r-base-latest Azure
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rstudio-r-base-4.1-opensuse153 Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 Github Actions
test-r-versions Github Actions
test-ubuntu-18.04-r-sanitizer Azure

@paleolimbot
Copy link
Member

I just kicked off a revdep run using:

cd path/to/arrow
R -e 'usethis::pr_fetch(33952)`
archery docker run r-revdepcheck

@paleolimbot
Copy link
Member

Ok - there are no changes for the worse reported by the archery revdep job; however, I'd like to test it by hand too using my hacked-together method (probably tomorrow morning).

@thisisnic thisisnic mentioned this pull request Feb 1, 2023
42 tasks
@thisisnic
Copy link
Member Author

OK, so the valgrind failure is one we know about, but wasn't the devdocs one that @paleolimbot already fixed?

@thisisnic
Copy link
Member Author

Ah, it's this: #33898

Though it's not failing on the nightlies any more.

@thisisnic
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Revision: 9543e10

Submitted crossbow builds: ursacomputing/crossbow @ actions-831234295c

Task Status
r-binary-packages Github Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants