GH-34106: [C++][Parquet] Fix updating page stats for WriteArrowDictionary

[wgtmac]

Rationale for this change

ColumnWriter::WriteArrowDictionary has tried to update stats but has problem if a single write has been split into batches and more than one page is written.

What changes are included in this PR?

Make sure every write of batch has updated the stats.

Are these changes tested?

Add test case which fails without the fix.

Are there any user-facing changes?

No.

• Closes: [C++][Parquet] Fix updating page statistics for WriteArrowDictionary #34106

[github-actions]

• Closes: [C++][Parquet] Fix updating page statistics for WriteArrowDictionary #34106

[github-actions]

⚠️ GitHub issue #34106 has been automatically assigned in GitHub to PR creator.

[wgtmac]

Converted to draft because I hit another issue: #14870. The C++ parquet reader does not parse column statistics correctly here: https://github.com/apache/arrow/blob/master/cpp/src/parquet/column_reader.cc#L214

// Extracts encoded statistics from V1 and V2 data page headers
template <typename H>
EncodedStatistics ExtractStatsFromHeader(const H& header) {
  EncodedStatistics page_statistics;
  if (!header.__isset.statistics) {
    return page_statistics;
  }
  const format::Statistics& stats = header.statistics;
  if (stats.__isset.max) {
    page_statistics.set_max(stats.max);
  }
  if (stats.__isset.min) {
    page_statistics.set_min(stats.min);
  }
  if (stats.__isset.null_count) {
    page_statistics.set_null_count(stats.null_count);
  }
  if (stats.__isset.distinct_count) {
    page_statistics.set_distinct_count(stats.distinct_count);
  }
  return page_statistics;
}

Once #34112 is merged, the test failure here will be recovered.

[wgtmac]

@westonpace @wjones127 Please take a look. Thanks!

[wjones127]

Thanks for fixing this!

[wgtmac]

Gentle ping @wjones127

[ursabot]

Benchmark runs are scheduled for baseline = 6850923 and contender = 476eb2e. 476eb2e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.46% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️1.02%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 476eb2ec ec2-t3-xlarge-us-east-2
[Failed] 476eb2ec test-mac-arm
[Finished] 476eb2ec ursa-i9-9960x
[Finished] 476eb2ec ursa-thinkcentre-m75q
[Finished] 6850923c ec2-t3-xlarge-us-east-2
[Failed] 6850923c test-mac-arm
[Finished] 6850923c ursa-i9-9960x
[Finished] 6850923c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java