Skip to content

GH-34148: [C++] Revert zstd back to 1.5.2#34190

Merged
kou merged 1 commit intoapache:masterfrom
mapleFU:dep/zstd-back-to-1-5-2
Feb 15, 2023
Merged

GH-34148: [C++] Revert zstd back to 1.5.2#34190
kou merged 1 commit intoapache:masterfrom
mapleFU:dep/zstd-back-to-1-5-2

Conversation

@mapleFU
Copy link
Member

@mapleFU mapleFU commented Feb 15, 2023

Rationale for this change

This patch part reverts #34114 . But it didn't revert the logic for url and sha256 change.

What changes are included in this PR?

zstd version revert back to v1.5.2

Are these changes tested?

no

Are there any user-facing changes?

no

@github-actions
Copy link

@mapleFU
Copy link
Member Author

mapleFU commented Feb 15, 2023

@kou @assignUser I didn't revert logic for using release url rather than sha256 here. Just revert zstd version

@kou
Copy link
Member

kou commented Feb 15, 2023

@github-actions crossbow submit example-cpp-minimal-build-static

@github-actions
Copy link

Revision: 65b0730

Submitted crossbow builds: ursacomputing/crossbow @ actions-c5c616cf7d

Task Status
example-cpp-minimal-build-static Github Actions

@mapleFU
Copy link
Member Author

mapleFU commented Feb 15, 2023

The building issue is same as #34188 ...

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We can ignore it for now.

@kou kou changed the title GH-34148: [C++] tools: revert zstd back to 1.5.2 GH-34148: [C++] Revert zstd back to 1.5.2 Feb 15, 2023
@kou kou merged commit e63215c into apache:master Feb 15, 2023
@ursabot
Copy link

ursabot commented Feb 15, 2023

Benchmark runs are scheduled for baseline = bef5876 and contender = e63215c. e63215c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.4% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.7% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e63215ca ec2-t3-xlarge-us-east-2
[Failed] e63215ca test-mac-arm
[Finished] e63215ca ursa-i9-9960x
[Finished] e63215ca ursa-thinkcentre-m75q
[Finished] bef5876f ec2-t3-xlarge-us-east-2
[Failed] bef5876f test-mac-arm
[Finished] bef5876f ursa-i9-9960x
[Finished] bef5876f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Feb 15, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Minimal build failed in crossbow because of zstd v1.5.4 requires CMake v3.18

3 participants