ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

kou · 2019-01-21T12:10:13Z

No description provided.

kszucs · 2019-01-21T12:32:48Z

How could We test this in an automatized way?

kou · 2019-01-21T12:40:48Z

I'm working: https://github.com/kou/arrow/tree/appveyor-msys :-)

codecov-io · 2019-01-21T12:50:04Z

Codecov Report

Merging #3443 into master will increase coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
+ Coverage   88.31%   89.29%   +0.98%     
==========================================
  Files         632      503     -129     
  Lines       79288    70321    -8967     
  Branches     1069        0    -1069     
==========================================
- Hits        70021    62793    -7228     
+ Misses       9152     7528    -1624     
+ Partials      115        0     -115

Impacted Files	Coverage Δ
cpp/src/arrow/util/sse-util.h	`100% <ø> (ø)`	⬆️
cpp/src/arrow/csv/column-builder.cc	`95.45% <0%> (-1.95%)`	⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349a957...bd8b8eb. Read the comment docs.

pitrou · 2019-01-21T17:34:38Z

cpp/src/arrow/util/sse-util.h


 static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
+#if defined(__MINGW32__) && !defined(__MINGW64__)
+  DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";


Did you run the tests or are you only concerned about building? This is pretty much not the right solution.

This is just for fixing build error.
I'm working on test support on MSYS2 in separated issues.
I'll be back again after we can run tests on MSYS2.

pitrou · 2019-01-21T17:36:37Z

The appropriate solution is something like this, though according to @jeroen it is insufficient:
https://gist.github.com/pitrou/f4282f68a8dc9b11fe931bd0eeb1f8af

jeroen · 2019-01-24T02:47:51Z

@pitrou your patch will probably work icw/ this PR. You do need to put the call to _mm_crc32_u64 behind a macro as Kohei as done here, otherwise it will give an error _mm_crc32_u64 undefined, even if you're not actually using that function.

pitrou · 2019-01-24T10:16:02Z

@jeroen Right. Can you open a PR for that?

Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from #3443. Author: Javier Luraschi <javierluraschi@hotmail.com> Author: Kouhei Sutou <kou@clear-code.com> Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits: e56dd14 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693"" 2ee894f <Javier Luraschi> Revert " Revert install python as suggested in pull/3693" 41ae266 <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure" e69b1e9 <Javier Luraschi> Revert install python as suggested in pull/3693 f2e4dfa <Javier Luraschi> Revert disabled test to investigate appveyor failure aa9f711 <Javier Luraschi> Install python as suggested in pull/3693 4cb63b1 <Javier Luraschi> Show error details in test as suggested in pull/3693 5b904fa <Javier Luraschi> Skip python since not installed in appveyor e0058b2 <Javier Luraschi> Skip failing tests to investigate later 3a0620f <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks 9c1d6e4 <Javier Luraschi> skip array-dict-test in win32 builds 057347a <Javier Luraschi> Install gflags as suggested in pull/3693 a24285b <Javier Luraschi> Remove allow_failures as suggested in pull/3693 695bdc9 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693 aad43b2 <Javier Luraschi> Apply patch discussed under pull/3443 219384f <Kouhei Sutou> Fix build error with MinGW-w64 32-bit

kou · 2019-03-01T06:30:38Z

Done by #3693.

Improvements for [ARROW-4297](https://issues.apache.org/jira/browse/ARROW-4297). This PR is a follow up to the discussed patch from apache/arrow#3443. Author: Javier Luraschi <javierluraschi@hotmail.com> Author: Kouhei Sutou <kou@clear-code.com> Closes #3693 from javierluraschi/bugfix/mingw32 and squashes the following commits: e56dd142 <Javier Luraschi> Revert "Revert " Revert install python as suggested in pull/3693"" 2ee894ff <Javier Luraschi> Revert " Revert install python as suggested in pull/3693" 41ae266e <Javier Luraschi> Revert " Revert disabled test to investigate appveyor failure" e69b1e95 <Javier Luraschi> Revert install python as suggested in pull/3693 f2e4dfa1 <Javier Luraschi> Revert disabled test to investigate appveyor failure aa9f7115 <Javier Luraschi> Install python as suggested in pull/3693 4cb63b17 <Javier Luraschi> Show error details in test as suggested in pull/3693 5b904fa4 <Javier Luraschi> Skip python since not installed in appveyor e0058b2a <Javier Luraschi> Skip failing tests to investigate later 3a0620f6 <Javier Luraschi> Use ARROW_BITNESS instead of MinGW checks 9c1d6e46 <Javier Luraschi> skip array-dict-test in win32 builds 057347a0 <Javier Luraschi> Install gflags as suggested in pull/3693 a24285ba <Javier Luraschi> Remove allow_failures as suggested in pull/3693 695bdc91 <Javier Luraschi> Add MinGW32 tests as suggested in pull/3693 aad43b2f <Javier Luraschi> Apply patch discussed under pull/3443 219384f0 <Kouhei Sutou> Fix build error with MinGW-w64 32-bit

[C++] Fix build error with MinGW-w64 32-bit

bd8b8eb

pitrou requested changes Jan 21, 2019

View reviewed changes

javierluraschi mentioned this pull request Feb 18, 2019

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3693

Closed

wesm force-pushed the master branch from 3088183 to 0c6b2d2 Compare February 18, 2019 19:34

kou closed this Mar 1, 2019

kou deleted the cpp-mingw-32 branch April 4, 2019 02:10

asfimport mentioned this pull request Apr 3, 2019

[C++] Fix build for 32-bit MSYS2 #20870

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

Uh oh!

kou commented Jan 21, 2019

Uh oh!

kszucs commented Jan 21, 2019

Uh oh!

kou commented Jan 21, 2019

Uh oh!

codecov-io commented Jan 21, 2019

Uh oh!

pitrou Jan 21, 2019

Uh oh!

kou Jan 25, 2019 •

edited

Loading

Uh oh!

pitrou commented Jan 21, 2019

Uh oh!

jeroen commented Jan 24, 2019 •

edited

Loading

Uh oh!

pitrou commented Jan 24, 2019

Uh oh!

kou commented Mar 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

Uh oh!

Conversation

kou commented Jan 21, 2019

Uh oh!

kszucs commented Jan 21, 2019

Uh oh!

kou commented Jan 21, 2019

Uh oh!

codecov-io commented Jan 21, 2019

Codecov Report

Uh oh!

pitrou Jan 21, 2019

Choose a reason for hiding this comment

Uh oh!

kou Jan 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pitrou commented Jan 21, 2019

Uh oh!

jeroen commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pitrou commented Jan 24, 2019

Uh oh!

kou commented Mar 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kou Jan 25, 2019 •

edited

Loading

jeroen commented Jan 24, 2019 •

edited

Loading