Skip to content

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kou wants to merge 1 commit into from
Closed

ARROW-4297: [C++] Fix build error with MinGW-w64 32-bit #3443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/src/arrow/util/sse-util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,12 @@ static inline uint32_t SSE4_crc32_u32(uint32_t crc, uint32_t v) {
}

static inline uint32_t SSE4_crc32_u64(uint32_t crc, uint64_t v) {
#if defined(__MINGW32__) && !defined(__MINGW64__)
DCHECK(false) << "MinGW-w64 32-bit doesn't support _mm_crc32_u64()";
Copy link
Member

@pitrou pitrou Jan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests or are you only concerned about building? This is pretty much not the right solution.

Copy link
Member Author

@kou kou Jan 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fixing build error.
I'm working on test support on MSYS2 in separated issues.
I'll be back again after we can run tests on MSYS2.

return 0;
#else
return static_cast<uint32_t>(_mm_crc32_u64(crc, v));
#endif
}

#else // without SSE 4.2.
Expand Down